docs(adr): ADR-0112 — one error-code vocabulary: SCREAMING_SNAKE + standard catalog + extension ledger (#3841) - #3967
Merged
Conversation
…andard catalog + extension ledger (#3841) Settles the spec decision in #3841: top-level error.code adopts SCREAMING_SNAKE via a two-tier vocabulary (closed StandardErrorCode catalog + ADR-0060-style registered extension ledger), ApiErrorSchema.code stops being z.string(), error-catalog.mdx becomes generated, field-level codes are explicitly split into their own follow-up decision, and the deviation from Prime Directive #3 is recorded with rationale. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MaSQn77TT5fUgHK9CesaDK
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MaSQn77TT5fUgHK9CesaDK
…e Directive #3 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MaSQn77TT5fUgHK9CesaDK
os-zhuang
marked this pull request as ready for review
July 30, 2026 00:36
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds ADR-0112, settling the spec decision requested in #3841: the platform's error-code vocabulary.
ADR only — no code changes in this PR. Implementation follows in the three batches the ADR's Rollout section defines (batch 1: spec rename + ledger + schema tightening; batch 2: lowercase emitter sweep; batch 3: location convergence).
The decision (D1–D9)
error.codeadopts SCREAMING_SNAKE;StandardErrorCode's 51 members are renamed in place (breaking, client updated in the same batch-1 PR).ApiErrorSchema.codestops beingz.string()and becomes the generated union — conformance suites gain value assertions with no test edits.error.code) for the semantic code;details.code/error.typeretired as carriers in batch 3 (unblocks the service-storage success bodies are three shapes, none carryingsuccess: true— the other half of #3675 #3689 sibling:error.codeoccupied by the HTTP status).FieldErrorSchema.code) are explicitly a separate vocabulary — schema widened to stop lying, own follow-up issue.error-catalog.mdxbecomes generated from spec.ErrorCategory/RetryStrategypair exported fromspec/integration/connector.zod.ts; fix the client's wrong-nesting read ofcategory/retryable.Why now
Every consumer that branches on error codes today lives in objectstack/objectui — the last window in which this rename is cheap. The #3687/#3837 conformance suites are already in place to enforce the outcome, and the
error.code-occupied-by-status fix is blocked until a vocabulary exists to migrate to.Review focus
FieldErrorSchema.codetoz.string()— honesty now vs enum later.Closes nothing yet; #3841 stays open until batch 1 lands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MaSQn77TT5fUgHK9CesaDK
Generated by Claude Code